fix: restore ComponentMap and ColorComponentMap in prelude for v0.8 compat#156
Open
lilith wants to merge 1 commit intokornelski:mainfrom
Open
fix: restore ComponentMap and ColorComponentMap in prelude for v0.8 compat#156lilith wants to merge 1 commit intokornelski:mainfrom
lilith wants to merge 1 commit intokornelski:mainfrom
Conversation
The v0.8 prelude exported ComponentMap and ColorComponentMap. The new prelude dropped them in favor of Pixel, HetPixel, etc. This breaks patch compatibility for code using `use rgb::prelude::*` with trait-qualified calls like `ComponentMap::map(...)` or method calls like `.map_c(...)`. Add both back alongside the new exports. ComponentMap is just a re-export of Pixel (same trait), and ColorComponentMap::map_c has no method name conflicts with any new prelude trait. Also adds CHANGELOG.md documenting formatting fixes, trait changes, and Gray v08→v09 migration guide.
lilith
force-pushed
the
prelude-backcompat
branch
from
9f4b1ef to
9872650
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComponentMapandColorComponentMaptorgb::preludealongside the new trait exports (Pixel,HetPixel, etc.)use rgb::prelude::*withComponentMap::map(...)or.map_c(...)breaks on upgrade from 0.8.41 — a semver violation for a patch releaseComponentMapis justPixelunder a different name;ColorComponentMap::map_chas no method name conflicts with any new prelude traitTest plan
cargo test --all --all-featurespassesComponentMap=Pixel(same trait),ColorComponentMap::map_cis unique